Welcome, Guest
Username Password: Remember me
Forgot your password? Forgot your username? Create an account
BibleStudy
BibleStudy 6.0.x and older
Help Forum

small bug
(1 viewing) (1) Guest
Reply Topic
New Topic
  • Page:
  • 1
  • 2

TOPIC: small bug

small bug 14 Apr 2008 18:15 #71

  • dhumphris
Hi Tom,
Thanks for the great new version. I'm just getting to know the new features.

There's one small bug on line 764 of views/studieslist/tmpl/default.php - I think you need to add:

  width=\"params->get('page_width');?>\"


Hope that code comes out right on the forum - basically add the width parameter with the value set in the component parameters.

Many thanks,
Doug
Reply Quote

Re:small bug 14 Apr 2008 18:33 #72

  • Tom
  • OFFLINE
  • Administrator
  • Posts: 860
The table width code actually comes on line 39:

table width=


$page_width is determined just prior:
$page_width = $this->params->get('page_width');
	if (!$page_width){
	$page_width = '100%';
	}


Adding it to line 764 doesn't seem to change anything. Did you notice a change?

Tom
"You shall know the truth and the truth shall set you free." JC
Reply Quote

Re:small bug 15 Apr 2008 08:39 #73

  • dhumphris
Okay, in that case all I need is to add 
width=\"100%\"
into line 764.

It does make a difference to me. I use a fluid template that stretches to the width of the window, and the list items don't stretch to 100% unless I add something into line 764. Perhaps it's a quirk with IE browser.


Here's a few more bugs I've noticed:

File studieslist/tmpl/default.php
Lines 874-892

I've noticed that the two icons for Text and PDF wrap one over the other. So i've changed the code to stick the PDF icon into its own TD cell:

 
 
params->get('show_full_text') > 0) { ?>
		id ); ?>
 
 
        params->get('tooltip') >0) { ?>
 
 
        get('text_image');?>\" alt=\"\" width=\"params->get('imagew');?>\" height=\"params->get('imageh');?>\" border=\"0\" >params->get('tooltip') >0) { ?>
 
 
 
params->get('show_pdf_text') > 0) { ?>
		id . '&format=pdf' ); ?>
 
 
 
 
 
 


Also moved the TDs inside the if statements.


------------
File mod_biblestudy/tmpl/_study.php
Lines 160, 174, 188, 202

The 8th option in the switch-case statement is \"series_text\" but when I set the module parameters in Admin the 8th option is \"Don't show\".


Thanks for all the work on this component. I'm revamping my church website and your work has saved me a lot of time and effort. A global ministry!

Doug
Reply Quote

Re:small bug 15 Apr 2008 12:42 #74

  • Tom
  • OFFLINE
  • Administrator
  • Posts: 860
Great work! Can you send me the files you modified by email and I'll include them for the next iterative release. The code doesn't show up well on this forum for some reason.

Blessings,

Tom
"You shall know the truth and the truth shall set you free." JC
Reply Quote

Re:small bug 15 Apr 2008 15:29 #75

  • dhumphris
I've attached the updated studieslist file.
I haven't attempted to fix the bug in the module.

Another small bug found:

mediaplayer/default.php
Line 227

I think you need to change mfid to study_id

Attachment default-69313f39aa46791a19417091f1f4d8f6.php not found
Reply Quote

Re:small bug 15 Apr 2008 15:48 #76

  • Tom
  • OFFLINE
  • Administrator
  • Posts: 860
Thanks again, Doug. I'll take a look at the file.

On the module - not sure I can see what you are talking about. In the Module Admin the 8th option is \"series\" and this seems to work on all four positions of the display. It is the module you are talking about, right? Not the component?

Tom
"You shall know the truth and the truth shall set you free." JC
Reply Quote
Reply Topic
New Topic
  • Page:
  • 1
  • 2
BibleStudy
BibleStudy 6.0.x and older
Help Forum
Moderators: Darren Vandermyde, Kyle
Powered by Kunena  Protected by Spam Fighter
Time to create page: 1.03 seconds