On the Teachers list display, only the first 5 teachers are displayed. If some of the first 5 are unpublished, then even less teachers are displayed. Bug must be somewhere in \components\com_biblestudy\views\teacherlist\tmpl\default_main.php
It seems, that the ID of the database entry is involved in this problem: If I delete the first teachers, the teacher with the ID '5' is the last displayed.


Another problem is connected with the teachers list:
A study may be released for registered user only. If you klick on the teacher, then ALL his studies are displayed regardless of the access level. So everybody may access studies targeted to registered uses only!


Also I found a minor bug in the template setting, teacher list view:
The 'Number of Studies in Teacher's view' may be anything bethween blank for all an any number. So the hepl text says. If you delete the cell contents, the default value 5 is set automatically.

Anton

I've put those in as bug reports. Thanks, Anton.

Here is what I found:

There was no check for the study to be published or for user level, so I added those to the db queries in /helpers/teacher.php and in the /views/teacherdisplay/view.html.php.

I changed the default value of the number of studies to show in the teacherdisplay view to blank. This seems to fix the problem, though if a number is not entered it will show all studies - which can be quite a list!

I was unable to replicate the problem with showing only 5 teachers. But there was a problem with this that was fixed in 6.2 Beta 2. Make sure that's the version you are using.

Tom

Hi Tom,
using the sources from today (copy from svn), the single teachers menue does not work at all. No single word, just empty window. IE7 says: HTTP 500 Interner Serverfehler (internal server error)

The number of studies per teacher in the teachers detail view now can be deleted in the template edit, so the setting is left blank. That's fine. Unfortunatelly, I cannot test the effect - see above.

Number of teachers in the teachers list: In the current template edit, there is no item to set the number and I cannot remember the state of the last week (short term memory The current situation is as follows: the last teacher is the teacher with the ID 6 (?!?). Unpublished teachers are not displayed - that's ok.

Anton

Hi Anton,

You are right, FireFox reports on the teacherdisplay:

Parse error: syntax error, unexpected $end in C:\xampp\htdocs\jbs2\components\com_biblestudy\views\teacherdisplay\tmpl\default_main.php on line 134

I'm off for the next week but I'll take a look when I return. Thanks for catching this.

I don't remember a setting in the template for number of teachers - hmmm

Tom

I have fixed this on the SVN. There was an extra bracket in the code - when you get those unexpected $end that's what usually is happening.

So have we solved all those issues? I wasn't sure what you meant about setting the number of teachers to display. Are you suggesting we have a parameter for the maximum number to display? You can now set whether a teacher should appear on the teachers list - that's while editing a specific teacher.

Tom