Welcome, Guest
Username Password: Remember me

Translation - some texts cannot be translated
(1 viewing) (1) Guest
When posting bug reports, please include as much detail as possible, including:
- your version of JBS,
- what view you were on,
- what task you were trying to perform,
- any error messages you encountered,
- step by step instructions to reproduce if possible.</ul>
If you have worked out a fix, upload the relevant file (renamed to .txt) and we'll update quickly!
  • Page:
  • 1

TOPIC: Translation - some texts cannot be translated

Translation - some texts cannot be translated 26 May 2010 12:43 #2229

  • Anton
  • OFFLINE
  • Moderator
  • Posts: 58
Hi,
I currently translate the component to german. During this I found some text, that cannot be translated due to several problems:

Site:
Following texts should be divided to get a translation file entry:
\site\controllers\podcastedit.php #135: JText::_($result.' saved')

There are several texts with a leading space. This is a problem, as Joomla! looks for exactly this string, but strings with leading spaces are specified as comments. Joomla! even states (docs.joomla.org/Creating_a_language_definition_file): The “KEY” can include spaces and other punctuation characters but there should not be any spaces either side of the equals sign as spaces are significant.... In fact, a trailing space seems not to be critical, but strings with leading spaces are 'not existing' in the ini-file.
Moreover, in Joomla! 1.6, no white spaces are allowed at all! (docs.joomla.org/Specification_of_language_files) This seems to me, that they want to 'push' the developers not to include the text in the php source files, but in the language files only.
Nevertheless, the strings with leading spaces are:
com_biblestudy\views\studieslist\tmpl\default_custom.php #145 JText::_(' [Edit] ')
com_biblestudy\views\mediafilesedit\tmpl\form.php #149 JText::_(' Item')
com_biblestudy\views\mediafilesedit\tmpl\form.php #218 JText::_( ' Or Upload File: ' );
com_biblestudy\views\mediafilesedit\tmpl\form.php #218 JText::_(' Try also using the Upload button a ....
com_biblestudy\helpers\textlink.php #55 JText::_(' - PDF Version');
com_biblestudy\helpers\listing.php #416 JText::_(' [Edit] ')
com_biblestudy\controllers\studydetails.php #283 JText::_(' has entered a comment for the study entitled: ')
com_biblestudy\controllers\studydetails.php #283 JText::_(' on: ')
com_biblestudy\controllers\studydetails.php #284 JText::_(' This comment has been published.')
com_biblestudy\controllers\studydetails.php #284 JText::_(' This comment has not been published.')
com_biblestudy\controllers\studydetails.php #285 JText::_(' You may review the comments by logging in to the site: ')

Some of the texts are sligtly different: With and without colon, with and without trailing space. Would it be a good ideat to unify them?
site:
'Comment: ' <-> 'Comment'
'Contact ' <-> 'Contact'
'Filesize: ' <-> 'Filesize'
'Full Name: ' <-> 'Full Name'
'Study: ' <-> 'Study'
'Thumbnail: ' <-> 'Thumbnail'

Admin:
I saw a strange empty string, but maybe this is ok:
com_biblestudy\lib\biblestudy.cpanel.php #206 <td><?php echo JText::_(); ?></td>

On following text, the JText::_ is missing:
com_biblestudy\lib\biblestudy.cpanel.php #107 php echo 'Joomla Bible Study'
com_biblestudy\lib\biblestudy.cpanel.php #108 php echo 'From here you can access all of the different views and tasks for ....
com_biblestudy\views\cpanel\tmpl\default.php #207 php echo 'Joomla Bible Study'?>
com_biblestudy\views\cpanel\tmpl\default.php #207 php echo 'From here you can access all of the different views and task ....

Should the following line be changed to JText::_?
com_biblestudy\controllers\templateedit.php #31 $msg = JText::sprintf('Template(s) have been copied');

Again, there are some strings with leading spaces:
com_biblestudy\views\admin\tmpl\form.php #49 to #55 ....JText::_(' Default for ......
com_biblestudy\views\mediafilesedit\tmpl\form.php #140 echo JText::_(' Item').': ';
com_biblestudy\views\mediafilesedit\tmpl\form.php #203 JText::_( ' Or Upload File: ' )
com_biblestudy\views\mediafilesedit\tmpl\form.php #203 JText::_(' Try also using the Upload button at the top. You will still h...

I also found some similar but slightly modified texts in the admin section:
'Full Name:' <-> 'Full Name'
'Image:' <-> 'Image'
'Server:' <-> 'Server'
'Study:' <-> 'Study'
'Thumbnail:' <-> 'Thumbnail'

Some strings will be hard to translate
\admin\models\templateedit.xml (6 times) ...Use HTML to create your repeatable template. Any HTML will do. ...

Some strings cannot be translated, as they start with a #. This character is used for comments in .ini files.
\admin\models\templateedit.xml:
# Books before break
# Locations before break
# Messagetypes before break
# Series before break
# Teachers before break
# Topics before break
# Years before break


I also append my current language files, both in english and german. Both are generated from the trunc, but still theay are not complete. But they are a good basis for other translators!

Best regards and blessing to you and the project
Anton

File Attachment:

File Name: language_de_en_2010_05_26.zip
File Size: 54646

Re: Translation - some texts cannot be translated 26 May 2010 12:52 #2230

  • Eugen
  • OFFLINE
  • Moderator
  • Posts: 147
Thank your for the detailed report. I can go ahead and address some of those issues.

You may also checkout the SVN version yourself, and commit changes to the SVN in case you find other consistency problems.

It is true, that the component needs quite a lot of refactoring, especially relating to the languages.
Last Edit: 26 May 2010 12:52 by Eugen.
  • Page:
  • 1
Moderators: Richard Hunt
Time to create page: 0.51 seconds